Skip to content

fix: add workflow permissions for thread resolution#3

Merged
monokrome merged 1 commit intomainfrom
fix/workflow-permissions
Mar 14, 2026
Merged

fix: add workflow permissions for thread resolution#3
monokrome merged 1 commit intomainfrom
fix/workflow-permissions

Conversation

@monokrome
Copy link
Member

Summary

  • Adds explicit pull-requests: write and contents: read permissions to the workflow
  • Required for the resolveReviewThread GraphQL mutation to work with GITHUB_TOKEN
  • Without this, the resolve call silently succeeds but doesn't actually resolve the thread

Test plan

  • Reply to a review comment acknowledging the concern
  • Verify the thread is resolved automatically

GITHUB_TOKEN needs explicit pull-requests: write to resolve
review threads via GraphQL.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added permissions block correctly grants the necessary permissions for a code review action to interact with pull requests and read repository content. This is a good and secure practice.

@monokrome monokrome merged commit ab30f1e into main Mar 14, 2026
1 check passed
@monokrome monokrome deleted the fix/workflow-permissions branch March 14, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant