fix: support prefix matching in v2 display field validation#284
Open
lcastillo-ledger wants to merge 1 commit intomainfrom
Open
fix: support prefix matching in v2 display field validation#284lcastillo-ledger wants to merge 1 commit intomainfrom
lcastillo-ledger wants to merge 1 commit intomainfrom
Conversation
The display field linter was using strict set comparison between format paths and ABI paths. This caused false positives when a descriptor defines a display field for an array root (e.g. `entries.[]`) while the ABI expands to individual leaf paths (e.g. `entries.[].alias`, `entries.[].address`). Use `data_path_starts_with` for prefix matching so that: - A format path is valid if it matches an ABI path or is a prefix of one - An ABI path is considered covered if a format path is a prefix of it Made-with: Cursor
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data_path_starts_withprefix matching instead of strict set equality when comparing format paths against ABI pathsContext
The v2 display field linter validates that format paths correspond to actual ABI paths and vice versa. It was using strict set difference, which fails when a descriptor defines a display field for an array root (e.g.
entries.[]) while the ABI expands into individual leaf paths (e.g.entries.[].alias,entries.[].address).This caused:
entries.[]that don't exist as exact ABI paths but are valid prefixesentries.[].aliasthat are already covered by a parent format pathWith prefix matching:
Test plan
AddAddressBookEntrywithentries.[].alias) → no false positive errorsMade with Cursor