Skip to content

fix: make domain.name optional in v2 to legacy EIP-712 conversion #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckorchane-ledger merged 2 commits into from
Mar 26, 2026
+3 −8
Merged

fix: make domain.name optional in v2 to legacy EIP-712 conversion #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
592fece
fix: make domain.name optional in v2 to legacy EIP-712 conversion
lcastillo-ledger Mar 24, 2026
908602e
Merge branch 'main' into fix/v2-optional-domain-name
ckorchane-ledger Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/erc7730/convert/ledger/eip712/convert_erc7730_v2_to_eip712.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,14 +483,6 @@ def _convert_resolved(
domain = context.eip712.domain
has_deployments = len(context.eip712.deployments) > 0

# Get dapp name from domain
dapp_name: str | None = domain.name if domain is not None else None
if dapp_name is None:
return out.error(
title="Missing domain name",
message="EIP-712 domain name is required for legacy EIP-712 conversion.",
)

# Get contract name from metadata
contract_name = descriptor.metadata.owner
if contract_name is None:
Expand All @@ -499,6 +491,9 @@ def _convert_resolved(
message="metadata.owner is required for legacy EIP-712 conversion.",
)

# Get dapp name: prefer domain.name, fall back to metadata.owner
dapp_name: str = (domain.name if domain is not None and domain.name is not None else None) or contract_name

# Reconstruct EIP712Domain type
domain_fields = _reconstruct_eip712_domain(domain, has_deployments, out)

Expand Down
Loading