Fix memory leak in handle_circular_pad#17
Open
jvwilliams23 wants to merge 1 commit intoLBANN:mainfrom
Open
Conversation
Avoid calling _ToTensor and _FromTensor in the function, as this was creating unfreed references. Instead, recursively call _handle_circular_pad. The first time will assign the relevant DCTensor attributes and modify the input padding. The second will apply the torch padding fn via super().__torch_function__(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
Avoid calling
_ToTensorand_FromTensorin the function, as this was creating un-freed (if that's a word?) references to the tensors.To get around this, we recursively call
_handle_circular_pad.The first time will assign the relevant DCTensor attributes and modify the input padding. The second will apply the torch padding fn via
super().__torch_function__(...)