Skip to content

Language: Added Russian ru.po & ru.mo files#39

Open
Reveritus wants to merge 5 commits intoJefferson49:mainfrom
Reveritus:main
Open

Language: Added Russian ru.po & ru.mo files#39
Reveritus wants to merge 5 commits intoJefferson49:mainfrom
Reveritus:main

Conversation

@Reveritus
Copy link

Full translate

@Jefferson49
Copy link
Owner

Thank you very much for providing the pull request! I would be glad to include the Russian translation. The ru.po file looks fine for me.

During review, I found two issues:

  • I worked on further features and created new translations. Would you mind creating a new pull request based on the latest code with further translations? I uploaded the latest code to GitHub now.
  • I do not quite understand the en.po file. English is already available as default language (en-GB). Seemingly, the en.po file contains a German translation. However, German (de.po) is also available. I would propose to not include the en.po file in the pull request.

@Reveritus
Copy link
Author

  • I worked on further features and created new translations. Would you mind creating a new pull request based on the latest code with further translations? I uploaded the latest code to GitHub now.

ru.po is currently linked to a my fork of the plugin, will it be updated when your source is updated? If so, then you don't need to change anything, I'll just give you a link to the project in poedit. If not, then you need to recreate the import from your source.

  • I do not quite understand the en.po file. English is already available as default language (en-GB). Seemingly, the en.po file contains a German translation. However, German (de.po) is also available. I would propose to not include the en.po file in the pull request.

POEditor.com for a long time, didn"t agree to import existing terms into a new ru.po file, and I did not find anything better than to create an en.po into which everything was imported at once. Next, I deleted this file, but everything happened within GitHub, from which nothing can be deleted.

@Reveritus
Copy link
Author

Thank you very much for providing the pull request! I would be glad to include the Russian translation. The ru.po file looks fine for me.

What can i do for approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants