Fix 47337: Ensure $login is never null when calling ilObjUser::_lookupId() (use …#11206
Closed
jheim2 wants to merge 2 commits intoILIAS-eLearning:release_11from
Closed
Fix 47337: Ensure $login is never null when calling ilObjUser::_lookupId() (use …#11206jheim2 wants to merge 2 commits intoILIAS-eLearning:release_11from
jheim2 wants to merge 2 commits intoILIAS-eLearning:release_11from
Conversation
…?? '') Prevent cronjob failure when $login is null
jheim2
changed the title
Contributor
|
Thanks for the Pr. I'm not completely happy with it due to $login being passed directly into the select query in i'll look into it |
Contributor
|
Again thanks for the PR and sorry for the delay. I chose to solve it with a wrapper method to prevent null or an empty string being passed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…?? '')
Prevent cronjob failure when $login is null