pygmt.grdmask: Create mask grid from polygons or point coverage(required arguments)

[Chuan1937]

Replace #4428

[seisman]

I feel this check is the same as the one above. Am I misunderstanding something?

[Chuan1937]

You understood correctly; the code you're writing now does contain duplicates. It's likely a mistake made while trying to solve formatting issues. The real intention was to check that when inside is a character pattern (like z or id), edge must be None or exactly the same as inside, preventing users from sending arbitrary numbers to edge.

[Chuan1937]

I've corrected it

[seisman]

Actually, I meant if we should delete this check.

[Chuan1937]

No. The first protection is that edge has a special value ("z"/"id"), but inside doesn't match.
The second protection is that inside has a special value, but edge provides a value that doesn't match.

[seisman]

Why not just check both cases like below:

if (inside in _inside_modes or edge in _inside_modes) and inside != edge:
    ...

[Chuan1937]

But it will rejects a valid case: inside set to z/id with edge unset (None).

[Chuan1937]

Let me think of a simpler and clearer way to express it.

[seisman]

It's almost done, but we still miss one parameter:

use -Np to use a running number as polygon ID; optionally append start of the sequence [0].

Not sure what the most suitable name for it is yet. Maybe id_start?

[Chuan1937]

I think so