fix: add structured metadata filtering to CZI dataset search#6
Open
LiudengZhang wants to merge 1 commit intoGenentech:mainfrom
Open
fix: add structured metadata filtering to CZI dataset search#6LiudengZhang wants to merge 1 commit intoGenentech:mainfrom
LiudengZhang wants to merge 1 commit intoGenentech:mainfrom
Conversation
…enentech#5) Update search_czi_datasets docstring and parameter descriptions to instruct the agent to pass organism and tissue as dedicated parameters instead of packing them into the query string. Replace silent filter drop with controlled relaxation (organism+tissue -> organism-only -> unfiltered) that includes a warning in the output when filters are relaxed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
search_czi_datasetsto actually use itsorganismandtissuefilter parameters, and warn when filters are relaxed instead of silently dropping them.Why
When the agent calls
search_czi_datasets({"query": "lung, Mus musculus", "n_datasets": 5}), the top results are irrelevant (embryo and skin datasets) because:queryand never passorganism/tissueseparately.n_datasetsrows, with no warning.How
Fielddescriptions to instruct the agent to passorganismandtissueas dedicated parameters, keepingqueryfor condition/context only.Closes #5