Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Kp IO implementation for retrieving and persisting SIDC Kp data, and exposes it via the swvo.io.kp package to be used alongside existing Kp sources.
Changes:
- Introduce
KpSIDCwith download, processing, persistence, and read logic for SIDC Kp data. - Export
KpSIDCfromswvo.io.kp.__init__for easier importing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
swvo/io/kp/sidc.py |
New SIDC Kp reader/downloader with monthly file slicing and a read() API similar to other Kp sources. |
swvo/io/kp/__init__.py |
Re-exports KpSIDC from the kp package namespace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore: addr copilot comments (part 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More commits will follow with additional sources and tests