--flash_gpu_descriptor: Keep bay power if already on#283
Open
JohnAZoidberg wants to merge 2 commits intomainfrom
Open
--flash_gpu_descriptor: Keep bay power if already on#283JohnAZoidberg wants to merge 2 commits intomainfrom
JohnAZoidberg wants to merge 2 commits intomainfrom
Conversation
JohnAZoidberg
requested review from
Copilot and
kiram9
and removed request for
kiram9
There was a problem hiding this comment.
Pull request overview
Adjusts --flash_gpu_descriptor behavior to avoid toggling expansion bay GPU power when it’s already enabled, preventing NVIDIA driver crashes/BSOD during EEPROM reprogramming on Windows.
Changes:
- Adds a GPIO read (
gpu_3v_5v_en) to decide whether bay power needs to be forced on during GPU EEPROM writes. - Attempts to only disable bay power after flashing if it was enabled by this command (via
force_power).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
Author
Use hide whitespace option to review |
84ffa84 made sure to turn on and off the bay power to enable programming the EEPROM even with bad eeprom (which would cause EC not to turn on bay power). But this would cause issue for reprogramming a good eeprom because the power is already on and it would turn it off afterwards. So if the bay power if turned off for a GPU when windows with nvidia driver is running, the driver crashes and bluescreens Windows. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
keep-bay-power
branch
from
1068457 to
82d1654
Compare
kiram9
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
84ffa84 made sure to turn on and off the bay power to enable programming the EEPROM even with bad eeprom (which would cause EC not to turn on bay power).
But this would cause issue for reprogramming a good eeprom because the power is already on and it would turn it off afterwards.
So if the bay power if turned off for a GPU when windows with nvidia driver is running, the driver crashes and bluescreens Windows.