Skip to content

ci: add jakarta.servlet-api to v25 profile#31

Merged
paodb merged 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Mar 25, 2026
Merged

ci: add jakarta.servlet-api to v25 profile#31
paodb merged 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #30

Summary by CodeRabbit

  • Chores
    • Updated test dependencies for improved build configuration and compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 30567dbf-7831-4a3a-9867-753304fe0595

📥 Commits

Reviewing files that changed from the base of the PR and between 38848ec and 63b7f86.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

A test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 was added to the v25 Maven profile in pom.xml. This resolves missing servlet API classes at test runtime when using Vaadin 25.1+, where this dependency was previously available transitively through a now-removed transitive.

Changes

Cohort / File(s) Summary
Maven v25 Profile Dependencies
pom.xml
Added explicit test-scoped dependency jakarta.servlet:jakarta.servlet-api:6.1.0 to v25 profile to provide servlet API classes required by serialization tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api — Directly addresses the root cause by adding the required jakarta.servlet-api dependency that was previously provided transitively by a removed transitive.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'ci: add jakarta.servlet-api to v25 profile' clearly and specifically describes the main change: adding the jakarta.servlet-api dependency to the v25 Maven profile.
Linked Issues check ✅ Passed The PR successfully implements the fix specified in issue #30: adding jakarta.servlet-api:6.1.0 as a test-scoped dependency to the v25 profile to resolve the SerializationTest failure.
Out of Scope Changes check ✅ Passed The changes are narrowly scoped to adding the required jakarta.servlet-api dependency to the v25 Maven profile, with no extraneous modifications or unrelated alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@javier-godoy javier-godoy marked this pull request as ready for review March 22, 2026 15:46
@paodb paodb merged commit 9d362f4 into master Mar 25, 2026
5 checks passed
@paodb paodb deleted the fix/v25-jakarta-servlet-api branch March 25, 2026 12:42
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api

2 participants