-
-
Notifications
You must be signed in to change notification settings - Fork 10
Convert Plotly to VTK.js and remove dist folder #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sridhar-mani
wants to merge
14
commits into
main
Choose a base branch
from
vtkjs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9161044
fix: removed dist and converted plotly into vtk js
sridhar-mani 2335be6
fix: converted into vtk js
sridhar-mani b4cd9f5
live delete
sridhar-mani b30a882
Add `prepare` and `pretest` lifecycle scripts to auto-build `dist/` (…
Copilot 46991c2
[WIP] WIP Address feedback on converting Plotly to VTK.js (#66)
Copilot d4447b2
Update src/visualization/vtkSolutionScript.js
sridhar-mani 89643f2
Update src/index.js
sridhar-mani f8927a9
[WIP] Update to address feedback on Plotly to VTK.js conversion (#67)
Copilot 9d191aa
fix: externatlise vtk js
sridhar-mani b052997
Revert "fix: externatlise vtk js"
sridhar-mani 6d5f966
fix: externalied vtk js
sridhar-mani bf1e0b5
fix: sepecific move
sridhar-mani 434ef04
fix: vtk issues
sridhar-mani c509948
feat: implemented both vtk js and plotly.
sridhar-mani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README now instructs users to install only
@kitware/vtk.js, but the codebase still supports a Plotly backend (renderOptions.backend === "plotly") andplotly.jsremains an (optional) peer dependency. Consider either documenting Plotly as an optional install (and how to select the backend) or removing Plotly support/dependencies to match the migration messaging.