-
Notifications
You must be signed in to change notification settings - Fork 9
Chunk logic error/bug in Component.
#210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
The9Cat
wants to merge
12
commits into
devel
Choose a base branch
from
chunkLogic
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8e0d766
Do not allow zero chunk size
The9Cat 0f783fe
Initial plan
Copilot 739a998
Update src/Component.cc
The9Cat 4de6ff2
Clamp chunk to [1, nbodies] to prevent HDF5 chunk dims exceeding data…
Copilot b4c76ef
Merge branch 'chunkLogic' into copilot/sub-pr-210
The9Cat 7be9753
Merge pull request #211 from EXP-code/copilot/sub-pr-210
The9Cat 80c6330
Update src/Component.cc
The9Cat 89cfc9c
Update src/Component.cc
The9Cat c19c4ce
Initial plan
Copilot 4a86266
Fix nbodies==0 chunk dims exceeding zero-length HDF5 dataspace
Copilot 6411bc5
Merge pull request #212 from EXP-code/copilot/sub-pr-210-again
The9Cat 1ba31df
Added some additional comments only [no ci]
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.