feat(ui): z-index mini framework via Tailwind custom tiers#8270
Open
enkr1 wants to merge 1 commit intoCoursemology:masterfrom
Open
feat(ui): z-index mini framework via Tailwind custom tiers#8270enkr1 wants to merge 1 commit intoCoursemology:masterfrom
enkr1 wants to merge 1 commit intoCoursemology:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5397
Problem
20+ hardcoded z-index values scattered across the codebase with no convention — values range from
1to9999with no semantic meaning or hierarchy.Changes
Tailwind z-index tiers (
tailwind.config.ts)z-basez-badgez-stickyz-overlayz-dropdownz-modalMigrated components
NotificationBar—9999→z-modalConfirmationDialog—9999→z-modalLoadingOverlay—110→z-overlayZoomActionElements—999→z-dropdownDashboard(learning map) —999→z-dropdownUnpublishedIcon—3→z-badgeNot migrated (intentionally)
z-index: 1500) — third-party DOM, can't use Tailwind classesnode.depth, must stay inline'1'values in inline styles, minor cleanup for a follow-upReference
Smashing Magazine: Z-Index for Large Projects