Added file drag-n-drop for opening them#3731
Draft
RobertoRoos wants to merge 2 commits intoControlSystemStudio:masterfrom
Draft
Added file drag-n-drop for opening them#3731RobertoRoos wants to merge 2 commits intoControlSystemStudio:masterfrom
RobertoRoos wants to merge 2 commits intoControlSystemStudio:masterfrom
Conversation
Author
|
I am completely new to Java and Phoebus, so I just started somewhere. The current version is extremely rough. |
RobertoRoos
commented
Mar 9, 2026
Comment on lines
+500
to
+511
| menuBar.setOnDragDropped(e -> { | ||
| final Dragboard db = e.getDragboard(); | ||
|
|
||
| if (db.hasFiles()) { | ||
| for (File file : db.getFiles()) { | ||
| this.openResource(file.toURI(), true); | ||
| } | ||
| } | ||
|
|
||
| e.setDropCompleted(true); | ||
| e.consume(); | ||
| }); |
Author
There was a problem hiding this comment.
This works, but causes the dragged-file icon to still show on top of the UI file the 'Choose editor' dialog is open.
What is a neat way to delay the openResource() call by a little bit?
RobertoRoos
commented
Mar 9, 2026
| toolbar = createToolbar(); | ||
| createTopResourcesMenu(); | ||
|
|
||
| menuBar.setOnDragOver(e -> { |
Author
There was a problem hiding this comment.
What would be a good location to put this event method? Because the event-handler should be shared, as I would like it to be called from other panels too.
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Added feature to allow drag-and-drop of files to open them.
Resolves #3730
Checklist
Testing:
Documentation: