Skip to content

Mp form fixes#510

Open
pikachu0542 wants to merge 3 commits intodevelopfrom
mp-form-fixes
Open

Mp form fixes#510
pikachu0542 wants to merge 3 commits intodevelopfrom
mp-form-fixes

Conversation

@pikachu0542
Copy link
Member

What

  • Added frontend validation for the MP form
  • Added red asterisks to visually indicate required fields
  • Added env var to bypass the slack ping on MP submission

Why

better user experience and easier dev testing

Test Plan

  • Try submitting the MP form with one or more required fields blank. Ensure that a popup appears preventing form submission
  • Try adding leading/trailing spaces to any of the text fields, ensure that the value that gets parsed into the JSON is trimmed
  • Try entering only spaces in one of the required fields (and something valid in all the others). Ensure that the form cannot be submitted
  • Set the new env var DEV_DISABLE_SLACK_PING to true, and verify that you can submit the MP form with no errors, even when the webhook url is invalid

Env Vars

Added a new variable DEV_DISABLE_SLACK_PING which is used in the major project code in order to provide a way to have the code not try to send a slack ping.

Documentation

I dont think any documentation was made out of date, and i think my new env var is self explanatory.

Checklist

  • Tested all changes locally

@pikachu0542 pikachu0542 self-assigned this Mar 13, 2026
@csh-sonarqube-community
Copy link

Passed Quality Gate passed

Issues

Measures

Project ID: ComputerScienceHouse_conditional_b4074151-bbfd-4fc3-b87d-10f1c1f625ab

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant