Skip to content

Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 1 | Structuring and Testing Data#1210

Open
Ofonimeedak wants to merge 1 commit intoCodeYourFuture:mainfrom
Ofonimeedak:coursework/sprint-1
Open

Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 1 | Structuring and Testing Data#1210
Ofonimeedak wants to merge 1 commit intoCodeYourFuture:mainfrom
Ofonimeedak:coursework/sprint-1

Conversation

@Ofonimeedak
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

PR contains the sprint 1 solution for structuring and testing data

@Ofonimeedak Ofonimeedak added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 7, 2026
@Ofonimeedak
Copy link
Author

Please kindly find the link to the former pull request here

Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good that you included a link to your previous PR, but you should also tag me to continue reviewing your changes.

Changes look good.

A variable name could be made more descriptive, but I will mark this PR as Complete first.

// e) What do you think the variable result represents? Can you think of a better name for this variable?

// the variable result represent total movie duration in hours,minute and seconds.
// const=runningTime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name runningTime still does not quite indicate the value stored in the variable
is a formatted string in the form "2:12:02".

One more try?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants