Manchester | ITP-JAN-26 | Ofonime Edak | Sprint 3 | Coursework/sprint 3 implement and rewrite#1139
Open
Ofonimeedak wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Ofonimeedak
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Ofonimeedak
added
the
Needs Review
cjyuan
reviewed
Mar 11, 2026
Comment on lines
+15
to
+19
| if(numerator>denominator) { | ||
| return false | ||
| }else{ | ||
| return true | ||
| } |
Contributor
There was a problem hiding this comment.
Can you lookup if -1/-2, 1/-2, -1/2, 1/0, -1/0 are considered proper fractions, and then update your code and tests accordingly?
Comment on lines
+41
to
+48
| test('throws on Invalid String', () => { | ||
| expect(() => { getCardValue('A10♠');}).toThrow("Invalid String"); | ||
| expect(() => { getCardValue('A');}).toThrow("Invalid String"); | ||
| expect(() => { getCardValue('110♠');}).toThrow("Invalid String"); | ||
| expect(() => { getCardValue(' ♠');}).toThrow("Invalid String"); | ||
| expect(() => { getCardValue('eeeeeej1234');}).toThrow("Invalid String"); | ||
|
|
||
| }); |
Contributor
There was a problem hiding this comment.
Does your function behave the way you expected from each of the following function calls?
getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("0002♠");
getCardValue("22");
| }); | ||
|
|
||
| // Case 5: Reflex angles | ||
| test(`Should return "Reflex angle" when (180>angle<360)`, () => { |
Contributor
There was a problem hiding this comment.
The notation (180>angle<360) is not consistent with the notation used on line 23.
| }); | ||
|
|
||
| // Case 6: Invalid angles | ||
| test(`Should return "Invalid angle" when (0 =<angle>=360)`, () => { |
Contributor
There was a problem hiding this comment.
How about (angle <= 0 or angle >=360)?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Angle functions
Proper fraction file
Resolved get Card Values
Write test with assertion
Rewrite test with Jest
This PR is on writing functions and carrying out unit test using JS assertion and jest