Conversation
Replace actor-level coloring with cell-based coloring. This allows distinct colors per cell type (vertices, edges, faces) rather than one color per actor.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
- Coverage 96.08% 95.54% -0.54%
==========================================
Files 29 30 +1
Lines 7961 10534 +2573
Branches 1190 1664 +474
==========================================
+ Hits 7649 10065 +2416
- Misses 179 312 +133
- Partials 133 157 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| reader.parseAsArrayBuffer(textEncoder.encode(shape)); | ||
|
|
||
| // setup actor,mapper and add | ||
| // create mesh types based on cell type for coloring |
There was a problem hiding this comment.
Shouldn't we just reuse the approach of fig/show of splitting into two actors on python side?
There was a problem hiding this comment.
Yes, let's go with your solution with multiple actors at least for now to fix the doc regression. I will close this PR. This change is kind of experimental.
I do have some concern over adding more actors and would like to revisit this later. I'm testing vtk.js performance with assemblies with large numbers of shapes. Performance degrades with many actors and a separate edge actor will not help. It's not an immediate issue for docs though.
I found a better approach may be to create one actor per assembly color instead of per shape.
|
@lorenzncode I'm reopening to not forget about this. |
2 participants
Replace actor-level coloring with cell-based coloring. This allows distinct colors per cell type (vertices, edges, faces) rather than one color per actor.