Skip to content

accessibility, fixed heading labels, missing lang attr #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davezuckerman merged 1 commit into from
Mar 19, 2026
Merged

accessibility, fixed heading labels, missing lang attr #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title><%= content_for?(:title) ? content_for(:title) : 'Early Arrivals Records Search (EARS)' %></title>
<%= stylesheet_link_tag :application %>
Expand All @@ -8,11 +8,11 @@
</head>
<body>
<div class="container">
<%= link_to image_tag(asset_path('nara.jpg'), alt: 'Chinese Immigration to the United States collection home'), "https://web.archive.org/web/20220124061848/https://bancroft.berkeley.edu/collections/chinese-immigration-to-the-united-states-1884-1944/index.html" %>
<%= link_to image_tag(asset_path('nara.jpg'), alt: 'Chinese Immigration to the United States collection home'), "https://web.archive.org/web/20220124061848/https://bancroft.berkeley.edu/collections/chinese-immigration-to-the-united-states-1884-1944/index.html", aria: { label: 'Open Chinese Immigration to the United States collection home' } %>
</div>
<div class="container">
<h2 class="display-3">The Early Arrivals Records Search (EARS)</h2>
<h4>A dataset from Investigation Arrival Case Files, San Francisco and Hawaii, Records of the U.S. Immigration and Naturalization Service, Record Group 85, National Archives at San Francisco.</h3>
<h1 class="display-3">The Early Arrivals Records Search (EARS)</h1>
<p>A dataset from Investigation Arrival Case Files, San Francisco and Hawaii, Records of the U.S. Immigration and Naturalization Service, Record Group 85, National Archives at San Francisco.</p>
</div>

<main>
Expand Down
4 changes: 1 addition & 3 deletions app/views/search_casefiles/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
<% end %>
</p>


<%= f.submit %>

<%= f.submit 'Search', aria: { label: 'Search case files' } %>

<% end %>

Loading