Skip to content

[PWGLF] Code clean up and add 2nd leg mixing in v3#15433

Merged
skundu692 merged 2 commits intoAliceO2Group:masterfrom
skundu692:spincorr_cleanup
Mar 17, 2026
Merged

[PWGLF] Code clean up and add 2nd leg mixing in v3#15433
skundu692 merged 2 commits intoAliceO2Group:masterfrom
skundu692:spincorr_cleanup

Conversation

@skundu692
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the pwglf label Mar 17, 2026
@github-actions github-actions bot changed the title Code clean up and add 2nd leg mixing in v3 [PWGLF] Code clean up and add 2nd leg mixing in v3 Mar 17, 2026
@vkucera
Copy link
Collaborator

vkucera commented Mar 17, 2026

Missing include

@skundu692 skundu692 enabled auto-merge (squash) March 17, 2026 21:24
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @skundu692.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 91a1cb3 at 2026-03-17 22:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15433-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1684:97: error: narrowing conversion of '(((double)(((lambdaspincorrderived*)this)->lambdaspincorrderived::ptMaxMixBuffer.o2::framework::Configurable<float>::o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::o2::framework::ConfigurableBase<float, o2::framework::kGeneric>.o2::framework::ConfigurableBase<float, o2::framework::kGeneric>::value - ((lambdaspincorrderived*)this)->lambdaspincorrderived::ptMinMixBuffer.o2::framework::Configurable<float>::o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::o2::framework::ConfigurableBase<float, o2::framework::kGeneric>.o2::framework::ConfigurableBase<float, o2::framework::kGeneric>::value)) / ((lambdaspincorrderived*)this)->lambdaspincorrderived::cfgKinematicBins.lambdaspincorrderived::<unnamed struct>::nKinematicPt.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::o2::framework::ConfigurableBase<double, o2::framework::kGeneric>.o2::framework::ConfigurableBase<double, o2::framework::kGeneric>::value)' from 'double' to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/15433-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1685:58: error: narrowing conversion of '((2.0e+0 * ((double)((lambdaspincorrderived*)this)->lambdaspincorrderived::v0etaMixBuffer.o2::framework::Configurable<float>::o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::o2::framework::ConfigurableBase<float, o2::framework::kGeneric>.o2::framework::ConfigurableBase<float, o2::framework::kGeneric>::value)) / ((lambdaspincorrderived*)this)->lambdaspincorrderived::cfgKinematicBins.lambdaspincorrderived::<unnamed struct>::nKinematicEta.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::o2::framework::ConfigurableBase<double, o2::framework::kGeneric>.o2::framework::ConfigurableBase<double, o2::framework::kGeneric>::value)' from 'double' to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/15433-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1686:25: error: narrowing conversion of '((2.0e+0 * TMath::Pi()) / ((lambdaspincorrderived*)this)->lambdaspincorrderived::cfgKinematicBins.lambdaspincorrderived::<unnamed struct>::nKinematicPhi.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::o2::framework::ConfigurableBase<double, o2::framework::kGeneric>.o2::framework::ConfigurableBase<double, o2::framework::kGeneric>::value)' from 'double' to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/15433-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1967:97: error: narrowing conversion of '(((double)(((lambdaspincorrderived*)this)->lambdaspincorrderived::ptMaxMixBuffer.o2::framework::Configurable<float>::o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::o2::framework::ConfigurableBase<float, o2::framework::kGeneric>.o2::framework::ConfigurableBase<float, o2::framework::kGeneric>::value - ((lambdaspincorrderived*)this)->lambdaspincorrderived::ptMinMixBuffer.o2::framework::Configurable<float>::o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::o2::framework::ConfigurableBase<float, o2::framework::kGeneric>.o2::framework::ConfigurableBase<float, o2::framework::kGeneric>::value)) / ((lambdaspincorrderived*)this)->lambdaspincorrderived::cfgKinematicBins.lambdaspincorrderived::<unnamed struct>::nKinematicPt.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::o2::framework::ConfigurableBase<double, o2::framework::kGeneric>.o2::framework::ConfigurableBase<double, o2::framework::kGeneric>::value)' from 'double' to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/15433-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1968:58: error: narrowing conversion of '((2.0e+0 * ((double)((lambdaspincorrderived*)this)->lambdaspincorrderived::v0etaMixBuffer.o2::framework::Configurable<float>::o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::o2::framework::ConfigurableBase<float, o2::framework::kGeneric>.o2::framework::ConfigurableBase<float, o2::framework::kGeneric>::value)) / ((lambdaspincorrderived*)this)->lambdaspincorrderived::cfgKinematicBins.lambdaspincorrderived::<unnamed struct>::nKinematicEta.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::o2::framework::ConfigurableBase<double, o2::framework::kGeneric>.o2::framework::ConfigurableBase<double, o2::framework::kGeneric>::value)' from 'double' to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/15433-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1969:25: error: narrowing conversion of '((2.0e+0 * TMath::Pi()) / ((lambdaspincorrderived*)this)->lambdaspincorrderived::cfgKinematicBins.lambdaspincorrderived::<unnamed struct>::nKinematicPhi.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::o2::framework::ConfigurableBase<double, o2::framework::kGeneric>.o2::framework::ConfigurableBase<double, o2::framework::kGeneric>::value)' from 'double' to 'float' [-Werror=narrowing]
ninja: build stopped: subcommand failed.

Full log here.

@skundu692 skundu692 merged commit cc70749 into AliceO2Group:master Mar 17, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants