Skip to content

[PWGCF] V02 analysis initial commit#15426

Merged
jaelpark merged 7 commits intoAliceO2Group:masterfrom
MaximVirta:V02
Mar 18, 2026
Merged

[PWGCF] V02 analysis initial commit#15426
jaelpark merged 7 commits intoAliceO2Group:masterfrom
MaximVirta:V02

Conversation

@MaximVirta
Copy link
Contributor

@MaximVirta MaximVirta commented Mar 17, 2026

Initial commit of V02 analysis with PID

@github-actions github-actions bot added the pwgcf label Mar 17, 2026
@alibuild alibuild mentioned this pull request Mar 17, 2026
Merged
@alibuild
Copy link
Collaborator

alibuild commented Mar 17, 2026

Error while checking build/O2Physics/o2 for fb07d71 at 2026-03-17 14:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:657:104: error: unused parameter 'run' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:493:49: error: unused parameter 'pidInd' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:530:83: error: unused parameter 'run' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:484:52: error: unused parameter 'vtxz' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:484:69: error: unused parameter 'pidInd' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Mar 17, 2026
View reviewed changes
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx
Comment on lines +195 to +198
kCharged = 0,
kPions,
kKaons,
kProtons
Copy link
Collaborator

@vkucera vkucera Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of the k prefix?

Copy link
Contributor Author

@MaximVirta MaximVirta Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same convention as in PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx

Copy link
Collaborator

@vkucera vkucera Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't answer the question.
Compile-time constants, including enumerations, are supposed to follow the UpperCamelCase naming convention.

Copy link
Contributor Author

@MaximVirta MaximVirta Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will change this in the next iteration as this got merged.

PWGCF/GenericFramework/Tasks/flowGfwV02.cxx
Comment on lines +201 to +206
iPionUp = 0,
iKaonUp,
iProtonUp,
iPionLow,
iKaonLow,
iProtonLow
Copy link
Collaborator

@vkucera vkucera Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow naming conventions.

Copy link
Contributor Author

@MaximVirta MaximVirta Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also from PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx, but "i" is used instead as an index in the arrays.

Copy link
Collaborator

@vkucera vkucera Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't change the fact that it violates the naming conventions.

Copy link
Contributor Author

@MaximVirta MaximVirta Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this one in UpperCamelCase as well?

Copy link
Collaborator

@vkucera vkucera Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are enumerations like any other.

@alibuild alibuild mentioned this pull request Mar 17, 2026
Merged
@MaximVirta
Merge pull request #21 from alibuild/alibot-cleanup-15426
5533a3b 
Please consider the following formatting changes to AliceO2Group#15426
@jaelpark jaelpark enabled auto-merge (squash) March 18, 2026 08:45
@jaelpark jaelpark merged commit 5b1b816 into AliceO2Group:master Mar 18, 2026
12 checks passed
@MaximVirta MaximVirta mentioned this pull request Mar 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@jaelpark jaelpark jaelpark approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaximVirta @alibuild @jaelpark @vkucera