fix for RunsPerLhcPeriodOverviewPage#2113
Closed
NarrowsProjects wants to merge 25 commits intomainfrom
Closed
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
- Coverage 45.55% 45.52% -0.04%
==========================================
Files 1044 1044
Lines 17327 17347 +20
Branches 3140 3146 +6
==========================================
+ Hits 7894 7897 +3
- Misses 9433 9450 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 9 commits
March 16, 2026 10:03
… prevent unneeded redraws
…a-pass page (#2109) * Prevent pagination from re-calling data pass id endpoint * Fetch items only when needed * Fetch runs from data pass only if pagination did not already do so * Trigger an immediate update in case observable already finished * Registration should happen only when page is loaded * Check if pagination triggered event More details: * request GET `dataPass` for specific id is sent 2 times instead of one because of pagination observer and initial loading page; * because of the double fetching, the summary request of QC periods is done also 2 times. Moreover, for each of the 2 times, the observer kicks in and does another 2 same requests, bringing the total to 4 summary requests fetching the same data in parallel (not even in sequence so that the browser can use its cache mechanism) * registration of events was moved to `load` methods as otherwise they will trigger in constructor (at load of application) * rename of miss-spelled words * total requests now down to 9 from 17 and loading times of all requests together for `runs-per-data-pass` halved
… split (#2110) - improved loading times of page runs-per-data-pass and prevent memory crash of the process due to heavy SQL queries - use sequalize separate function to split big SQL join queries
Bumps [sequelize](https://github.com/sequelize/sequelize) from 6.37.0 to 6.37.8. - [Release notes](https://github.com/sequelize/sequelize/releases) - [Changelog](https://github.com/sequelize/sequelize/blob/main/CHANGELOG.md) - [Commits](sequelize/sequelize@v6.37.0...v6.37.8) --- updated-dependencies: - dependency-name: sequelize dependency-version: 6.37.8 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: George R. <george.raduta@cern.ch>
…by re-instantiating them.
NarrowsProjects
force-pushed
the
improv/O2B-1556/fix-failing-tests
branch
from
a4887a2 to
e588624
Compare
NarrowsProjects
force-pushed
the
improv/O2B-1556/fix-failing-tests
branch
from
be92df2 to
b6d7e87
Compare
NarrowsProjects
force-pushed
the
improv/O2B-1556/fix-failing-tests
branch
from
b3e3eeb to
ee6b786
Compare
…toring table data before it changes instead of after it
Collaborator
Author
|
Branch has been split into two different branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: