Skip to content

Correctly handle errors in merging histograms with kAverage #15189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knopers8 wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

Correctly handle errors in merging histograms with kAverage #15189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Utilities/Mergers/src/MergerAlgorithm.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Long64_t mergeDefault(TObject* const target, TObject* const other)
// Merge() does not support averages, we have to use Add()
// this will break if collection.size != 1
if (auto otherTH1 = dynamic_cast<TH1*>(otherCollection.First())) {
errorCode = targetTH1->Add(otherTH1);
errorCode = targetTH1->Add(otherTH1) == kFALSE ? -1 : 0;
}
} else {
// Add() does not support histograms with labels, thus we resort to Merge() by default
Expand Down
Loading