From 8904cde502e987adf90b25709c2dd0acea902c09 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 11:32:31 +0200 Subject: [PATCH 01/21] test --- simple.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/simple.yaml b/simple.yaml index b635d93..876f6fd 100644 --- a/simple.yaml +++ b/simple.yaml @@ -31,6 +31,7 @@ components: type: string required: - name + - id paths: /api/v1.0/groups: post: From 5f49d42c2e0b6a0a5f9a07cf12848eb508d1ee53 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 11:35:02 +0200 Subject: [PATCH 02/21] test --- .github/workflows/oasdiff.yml | 21 --------------------- 1 file changed, 21 deletions(-) delete mode 100644 .github/workflows/oasdiff.yml diff --git a/.github/workflows/oasdiff.yml b/.github/workflows/oasdiff.yml deleted file mode 100644 index ed97d9f..0000000 --- a/.github/workflows/oasdiff.yml +++ /dev/null @@ -1,21 +0,0 @@ -name: oasdiff - -on: - pull_request: - -permissions: - pull-requests: write - -jobs: - oasdiff: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v6 - - - run: git fetch --depth=1 origin ${{ github.base_ref }} - - - uses: oasdiff/oasdiff-action/pr-comment@v0.0.31 - with: - base: 'origin/${{ github.base_ref }}:simple.yaml' - revision: 'HEAD:simple.yaml' - oasdiff-token: ${{ secrets.OASDIFF_TOKEN }} From 5f65a9241cb2daab75de5aaa0ea247a466608842 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 11:50:29 +0200 Subject: [PATCH 03/21] x --- simple.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index 876f6fd..b635d93 100644 --- a/simple.yaml +++ b/simple.yaml @@ -31,7 +31,6 @@ components: type: string required: - name - - id paths: /api/v1.0/groups: post: From d74594c774bb1092d181a8198fcb23d1fcb6e7a7 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 12:11:53 +0200 Subject: [PATCH 04/21] id required --- simple.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/simple.yaml b/simple.yaml index b635d93..876f6fd 100644 --- a/simple.yaml +++ b/simple.yaml @@ -31,6 +31,7 @@ components: type: string required: - name + - id paths: /api/v1.0/groups: post: From 7b3190e85c078a5099d8e3aa4298d2f74d93c72c Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:23:04 +0200 Subject: [PATCH 05/21] get groups --- simple.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/simple.yaml b/simple.yaml index 876f6fd..fc5bc33 100644 --- a/simple.yaml +++ b/simple.yaml @@ -34,6 +34,22 @@ components: - id paths: /api/v1.0/groups: + get: + tags: + - Group + operationId: getGroups + parameters: + - $ref: '#/components/parameters/groupId' + responses: + "200": + content: + application/json: + schema: + type: array + items: + $ref: '#/components/schemas/GroupView' + description: SUCCESS + summary: Get Projects post: tags: - Group From 7efadf8a0b3b38a8ced115d8c1420ece3911366e Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:24:34 +0200 Subject: [PATCH 06/21] str->num --- simple.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index fc5bc33..f8e87ff 100644 --- a/simple.yaml +++ b/simple.yaml @@ -25,7 +25,7 @@ components: readOnly: true pattern: "^[a-z]+$" id: - type: string + type: number readOnly: true name: type: string From 359db22aa9ed439a517619e4b3abcba84bab7f3f Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:26:31 +0200 Subject: [PATCH 07/21] x --- simple.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index f8e87ff..3dd5385 100644 --- a/simple.yaml +++ b/simple.yaml @@ -11,7 +11,7 @@ components: name: groupId required: false schema: - type: string + type: number schemas: GroupView: type: object From 62e11b8f4efebe7de690a94d341f3022c7410000 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:28:23 +0200 Subject: [PATCH 08/21] required --- simple.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index 3dd5385..80e1a12 100644 --- a/simple.yaml +++ b/simple.yaml @@ -9,7 +9,7 @@ components: groupId: in: query name: groupId - required: false + required: true schema: type: number schemas: From 79593b25efe33fea04731c1d5e684fe255d0a132 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:29:27 +0200 Subject: [PATCH 09/21] x --- simple.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/simple.yaml b/simple.yaml index 80e1a12..a2152c2 100644 --- a/simple.yaml +++ b/simple.yaml @@ -12,6 +12,7 @@ components: required: true schema: type: number + readOnly: true schemas: GroupView: type: object From 4321dac0852e1c98cac285046fc87987f37f5c47 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:30:17 +0200 Subject: [PATCH 10/21] x --- simple.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/simple.yaml b/simple.yaml index a2152c2..fe2c270 100644 --- a/simple.yaml +++ b/simple.yaml @@ -11,8 +11,10 @@ components: name: groupId required: true schema: - type: number - readOnly: true + type: object + properties: + id: + type: number schemas: GroupView: type: object From cf80f0f305ed2d56770a1b8838b438f099c0de6d Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:31:54 +0200 Subject: [PATCH 11/21] x --- simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/simple.yaml b/simple.yaml index fe2c270..9d87732 100644 --- a/simple.yaml +++ b/simple.yaml @@ -32,6 +32,8 @@ components: readOnly: true name: type: string + email: + type: string required: - name - id From b8161fbc761c468b4827dc121f351bea8a95bff5 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:32:29 +0200 Subject: [PATCH 12/21] x --- simple.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/simple.yaml b/simple.yaml index 9d87732..f7d293b 100644 --- a/simple.yaml +++ b/simple.yaml @@ -37,6 +37,7 @@ components: required: - name - id + - email paths: /api/v1.0/groups: get: From 8489cd96775cda4a8b201760efa654a589891c43 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:33:07 +0200 Subject: [PATCH 13/21] x --- simple.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index f7d293b..fc83091 100644 --- a/simple.yaml +++ b/simple.yaml @@ -36,7 +36,6 @@ components: type: string required: - name - - id - email paths: /api/v1.0/groups: From a5ff021223dee706f81099646785e9166ad5d4b1 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:34:33 +0200 Subject: [PATCH 14/21] x --- simple.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/simple.yaml b/simple.yaml index fc83091..56287a4 100644 --- a/simple.yaml +++ b/simple.yaml @@ -28,8 +28,7 @@ components: readOnly: true pattern: "^[a-z]+$" id: - type: number - readOnly: true + type: string name: type: string email: From 0d60254cb12a590af99254b8aebb63c2ada706eb Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:39:23 +0200 Subject: [PATCH 15/21] x --- simple.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/simple.yaml b/simple.yaml index 56287a4..35b1f19 100644 --- a/simple.yaml +++ b/simple.yaml @@ -29,6 +29,7 @@ components: pattern: "^[a-z]+$" id: type: string + readOnly: true name: type: string email: From a59806a47555799e2e22af002eff27d5c80ff8fe Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 13:43:49 +0200 Subject: [PATCH 16/21] x --- simple.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index 35b1f19..7080fb5 100644 --- a/simple.yaml +++ b/simple.yaml @@ -26,7 +26,7 @@ components: type: string format: date-time readOnly: true - pattern: "^[a-z]+$" + pattern: "^[A-Z]+$" id: type: string readOnly: true From e9ca038779a7e683a83ed1c61e5f764d3f23335d Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 16:11:13 +0200 Subject: [PATCH 17/21] test breaking --- .github/workflows/pr-comment.yml | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr-comment.yml b/.github/workflows/pr-comment.yml index 2e5b105..6ff51d9 100644 --- a/.github/workflows/pr-comment.yml +++ b/.github/workflows/pr-comment.yml @@ -1,23 +1,20 @@ -name: oasdiff PR comment +name: API Breaking Change Check on: pull_request: - -permissions: - contents: read - pull-requests: write - statuses: write + paths: + - 'openapi/**' # adjust to your spec location jobs: - pr-comment: + breaking-changes: runs-on: ubuntu-latest steps: - - name: Check out code - uses: actions/checkout@v4 + - uses: actions/checkout@v6.0.2 + + - run: git fetch --depth=1 origin ${{ github.base_ref }} - - name: Post oasdiff PR comment - uses: oasdiff/oasdiff-action/pr-comment@v0.0.34 - with: - base: https://raw.githubusercontent.com/${{ github.repository }}/${{ github.base_ref }}/simple.yaml - revision: simple.yaml - oasdiff-token: 0634345d-02fb-43df-b56a-68fc22253621 + - uses: oasdiff/oasdiff-action/breaking@v0.0.34 + with: + base: 'origin/${{ github.base_ref }}:simple.yaml' + revision: 'HEAD:simple.yaml' + fail-on: ERR From 6d935390814e077249bc564f2f4bc1296ff60a94 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 16:11:57 +0200 Subject: [PATCH 18/21] x --- simple.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple.yaml b/simple.yaml index 7080fb5..9c993b7 100644 --- a/simple.yaml +++ b/simple.yaml @@ -36,7 +36,7 @@ components: type: string required: - name - - email + - email1 paths: /api/v1.0/groups: get: From 1de00921f064ad5703edb7b33b22c24885f46317 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 16:13:05 +0200 Subject: [PATCH 19/21] x --- .github/workflows/pr-comment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-comment.yml b/.github/workflows/pr-comment.yml index 6ff51d9..6afbd3e 100644 --- a/.github/workflows/pr-comment.yml +++ b/.github/workflows/pr-comment.yml @@ -3,7 +3,7 @@ name: API Breaking Change Check on: pull_request: paths: - - 'openapi/**' # adjust to your spec location + - 'simple.yaml' jobs: breaking-changes: From ffcbb51111ede91b47fb6bfb3ad871f8ed490bfd Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 16:14:49 +0200 Subject: [PATCH 20/21] s --- .github/workflows/pr-comment.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-comment.yml b/.github/workflows/pr-comment.yml index 6afbd3e..adf3ee7 100644 --- a/.github/workflows/pr-comment.yml +++ b/.github/workflows/pr-comment.yml @@ -9,11 +9,11 @@ jobs: breaking-changes: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v6.0.2 + - uses: actions/checkout@v6 - run: git fetch --depth=1 origin ${{ github.base_ref }} - - uses: oasdiff/oasdiff-action/breaking@v0.0.34 + - uses: oasdiff/oasdiff-action/breaking@v0.0.35 with: base: 'origin/${{ github.base_ref }}:simple.yaml' revision: 'HEAD:simple.yaml' From 95a564e1ada071fdb0f4cea38d300faf85edbe58 Mon Sep 17 00:00:00 2001 From: Reuven Harrison Date: Sat, 21 Mar 2026 16:31:46 +0200 Subject: [PATCH 21/21] main --- .github/workflows/pr-comment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-comment.yml b/.github/workflows/pr-comment.yml index adf3ee7..0f397e6 100644 --- a/.github/workflows/pr-comment.yml +++ b/.github/workflows/pr-comment.yml @@ -13,7 +13,7 @@ jobs: - run: git fetch --depth=1 origin ${{ github.base_ref }} - - uses: oasdiff/oasdiff-action/breaking@v0.0.35 + - uses: oasdiff/oasdiff-action/breaking@main with: base: 'origin/${{ github.base_ref }}:simple.yaml' revision: 'HEAD:simple.yaml'