fix: harden invalid graphml import handling#374
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
fix: harden invalid graphml import handling#374avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
@pradeeban This patch hardens malformed GraphML import handling so users get a clear error instead of runtime failure, pls take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix invalid GraphML import handling
Malformed/partial GraphML was failing inconsistently and could blow up in import flow.
This patch makes import failure deterministic:
parser now rejects on invalid XML/GraphML
import handlers catch and show Invalid GraphML file.
applied in both toolbar import and setGraphML() path
closes #373