From c3c5c5b1580a289d2ed26ee3233356608356db85 Mon Sep 17 00:00:00 2001 From: Francesca Ercolessi Date: Wed, 18 Mar 2026 12:48:26 +0100 Subject: [PATCH 1/3] Fix for crash when updating plot --- Modules/TOF/src/TrendingCalibDiagnostics.cxx | 2 ++ Modules/TOF/src/TrendingCalibLHCphase.cxx | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Modules/TOF/src/TrendingCalibDiagnostics.cxx b/Modules/TOF/src/TrendingCalibDiagnostics.cxx index 1c9df08cae..f868e580cd 100644 --- a/Modules/TOF/src/TrendingCalibDiagnostics.cxx +++ b/Modules/TOF/src/TrendingCalibDiagnostics.cxx @@ -216,6 +216,8 @@ void TrendingCalibDiagnostics::generatePlots() title->SetBBoxCenterX(c->GetBBoxCenter().fX); // It will have an effect only after invoking Draw again. title->Draw(); + c->Modified(); + c->Update(); } else { ILOG(Error, Devel) << "Could not get the title TPaveText of the plot '" << plot.name << "'." << ENDM; } diff --git a/Modules/TOF/src/TrendingCalibLHCphase.cxx b/Modules/TOF/src/TrendingCalibLHCphase.cxx index bc14c8b344..441649f136 100644 --- a/Modules/TOF/src/TrendingCalibLHCphase.cxx +++ b/Modules/TOF/src/TrendingCalibLHCphase.cxx @@ -186,6 +186,8 @@ void TrendingCalibLHCphase::generatePlots() title->SetBBoxCenterX(c->GetBBoxCenter().fX); // It will have an effect only after invoking Draw again. title->Draw(); + c->Modified(); + c->Update(); } else { ILOG(Error, Devel) << "Could not get the title TPaveText of the plot '" << plot.name << "'." << ENDM; } From 2a3c2d8f888eaaa4a45271553f56c8b1dffc60e7 Mon Sep 17 00:00:00 2001 From: Francesca Ercolessi Date: Wed, 18 Mar 2026 12:50:02 +0100 Subject: [PATCH 2/3] fix --- Modules/TOF/src/TrendingCalibDiagnostics.cxx | 1 - Modules/TOF/src/TrendingCalibLHCphase.cxx | 1 - 2 files changed, 2 deletions(-) diff --git a/Modules/TOF/src/TrendingCalibDiagnostics.cxx b/Modules/TOF/src/TrendingCalibDiagnostics.cxx index f868e580cd..ad83cff584 100644 --- a/Modules/TOF/src/TrendingCalibDiagnostics.cxx +++ b/Modules/TOF/src/TrendingCalibDiagnostics.cxx @@ -215,7 +215,6 @@ void TrendingCalibDiagnostics::generatePlots() if (auto title = dynamic_cast(c->GetPrimitive("title"))) { title->SetBBoxCenterX(c->GetBBoxCenter().fX); // It will have an effect only after invoking Draw again. - title->Draw(); c->Modified(); c->Update(); } else { diff --git a/Modules/TOF/src/TrendingCalibLHCphase.cxx b/Modules/TOF/src/TrendingCalibLHCphase.cxx index 441649f136..987873ade0 100644 --- a/Modules/TOF/src/TrendingCalibLHCphase.cxx +++ b/Modules/TOF/src/TrendingCalibLHCphase.cxx @@ -185,7 +185,6 @@ void TrendingCalibLHCphase::generatePlots() if (auto title = dynamic_cast(c->GetPrimitive("title"))) { title->SetBBoxCenterX(c->GetBBoxCenter().fX); // It will have an effect only after invoking Draw again. - title->Draw(); c->Modified(); c->Update(); } else { From 313e6960d1b532dcecea4b870f8984b00af5c8b7 Mon Sep 17 00:00:00 2001 From: Francesca Ercolessi Date: Wed, 18 Mar 2026 14:05:28 +0100 Subject: [PATCH 3/3] remove comment --- Modules/TOF/src/TrendingCalibDiagnostics.cxx | 1 - Modules/TOF/src/TrendingCalibLHCphase.cxx | 1 - 2 files changed, 2 deletions(-) diff --git a/Modules/TOF/src/TrendingCalibDiagnostics.cxx b/Modules/TOF/src/TrendingCalibDiagnostics.cxx index ad83cff584..fc912c8816 100644 --- a/Modules/TOF/src/TrendingCalibDiagnostics.cxx +++ b/Modules/TOF/src/TrendingCalibDiagnostics.cxx @@ -214,7 +214,6 @@ void TrendingCalibDiagnostics::generatePlots() // After the update, the title has a different size and it is not in the center anymore. We have to fix that. if (auto title = dynamic_cast(c->GetPrimitive("title"))) { title->SetBBoxCenterX(c->GetBBoxCenter().fX); - // It will have an effect only after invoking Draw again. c->Modified(); c->Update(); } else { diff --git a/Modules/TOF/src/TrendingCalibLHCphase.cxx b/Modules/TOF/src/TrendingCalibLHCphase.cxx index 987873ade0..2b73942b4d 100644 --- a/Modules/TOF/src/TrendingCalibLHCphase.cxx +++ b/Modules/TOF/src/TrendingCalibLHCphase.cxx @@ -184,7 +184,6 @@ void TrendingCalibLHCphase::generatePlots() // After the update, the title has a different size and it is not in the center anymore. We have to fix that. if (auto title = dynamic_cast(c->GetPrimitive("title"))) { title->SetBBoxCenterX(c->GetBBoxCenter().fX); - // It will have an effect only after invoking Draw again. c->Modified(); c->Update(); } else {