Skip to content

Fix GPU b-field initialization#15143

Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02:pr_gpubfld0
Mar 17, 2026
Merged

Fix GPU b-field initialization#15143
shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02:pr_gpubfld0

Conversation

@shahor02
Copy link
Collaborator

The 12kA L3 field should be scaled wrt its own nominal rather than 30kA nominal Bz. Keep the old scaling for backward compatibility.

Don't merge until TPC CTF decoding with field Bz from the CTF itself is not ready, as this PR will crash low-field data decoding.

Example of difference:

// original field for -12kA:
auto f2 = o2::field::MagneticField::createFieldMap(-12000, -6000);
f2->GetBz(120, 120, -20)
(double) -2.0522978

// old gpu field initialized with -12kA:
fld.GetFieldBz(120, 120, -20)/0.000299792458f
(float) -2.00946f
// -> 2.1% difference

// field with this PR initialized with -12kA 
fld.GetFieldBz(120, 120, -20)/0.000299792458f
(float) -2.05180f
// -> 0.024% difference

@shahor02 shahor02 requested a review from davidrohr as a code owner March 10, 2026 23:01
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

The 12kA L3 field should be scaled wrt its own nominal rather than 30kA nominal Bz.
Keep the old scaling for backward compatibility
@shahor02
Copy link
Collaborator Author

removed getNominalGPUBzOld since it will never be used.

@alcaliva alcaliva enabled auto-merge (squash) March 17, 2026 06:44
@shahor02 shahor02 disabled auto-merge March 17, 2026 08:24
@shahor02 shahor02 merged commit 6f830a2 into AliceO2Group:dev Mar 17, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant